[chore] Clean up config handling in target allocator #2470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swiatekm
force-pushed
the
chore/targetallocator-config
branch
from
c3ee482
to
28b94ef
Compare
swiatekm
force-pushed
the
chore/targetallocator-config
branch
from
28b94ef
to
aa30999
Compare
jaronoff97
approved these changes
Jan 9, 2024
ItielOlenick
pushed a commit
to ItielOlenick/opentelemetry-operator
that referenced
this pull request
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made defaults for some options easier to work with by following Go conventions - used string values with an empty string signifying no value, instead of pointers.
I've also made an internal change to target allocator, where it's now clear that we only use scrape configs out of the Prometheus config, and ignore everything else. I'd like to make this more explicit in the future and reject configurations which include anything other than scrape configs.